Fixing intermittent OSX test failure issue due to low default filehandle limit #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 59.28% // Head: 59.29% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #613 +/- ##
========================================
Coverage 59.28% 59.29%
========================================
Files 82 82
Lines 11503 11503
Branches 1858 1858
========================================
+ Hits 6820 6821 +1
Misses 3149 3149
+ Partials 1534 1533 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
cxloe
reviewed
Dec 1, 2022
cxloe
approved these changes
Dec 1, 2022
Co-authored-by: cxloe <77425619+cxloe@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
On OSX, tests sometimes fail with an error like "panicked at 'Could not create ledger_db: LMDB: Too many open files'"
In this PR
Test Plan
./tools/test.shFuture Work